[PATCH] D20067: Error if inline assembly ends in unexpected mode

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 11:58:04 PDT 2016


niravd added a comment.

ARM has a similar situation arise in their code but uses a different fix. There, this situation is fixed if needed if we use the integrated assembler and otherwise always emits a directive in no integrated assembler case. This guarantees any code llvm generates is always correct, but leaves no notification that there is a potential latent bug should you compile with a separate compiler.

We should be consistent here and either change ARM to also emit an error or change both to emit warnings.


http://reviews.llvm.org/D20067





More information about the llvm-commits mailing list