[PATCH] D19181: Map Attribute in the C API.

[James Y Knight via llvm-commits]

jyknight added a comment.

Thanks! Now that I can actually see your proposal, I can respond to it.

There's some things missing:

- No way to enumerate which attributes are present.
- No way to access or create integer-valued attributes.
- No way to access or create string attributes.

The LLVMGetCallSiteAttr (and related) function is missing an "index" parameter -- at least I assume you mean for there to be such a parameter, like the old LLVMGetInstrAttribute?

If so: why does it make sense to have one function that handles all of function, return, and param attributes for call instructions, depending on the value of an index parameter, but to use three functions to do the same for declarations/definitions?

If not: can you clarify what the intended usage of the function is?


http://reviews.llvm.org/D19181