[PATCH] D20074: Add support for metadata attachments for global variables.

[Adrian Prantl via llvm-commits]

aprantl added a comment.

Small nitpicks after a quick read-through.


================
Comment at: include/llvm/IR/GlobalObject.h:74
@@ -65,1 +73,3 @@
 
+  /// \brief Check if this has any metadata.
+  bool hasMetadata() const { return hasMetadataHashEntry(); }
----------------
FYI: We run doxygen with auto-brief now. This makes "\brief" in redundant for one-sentence first paragraphs. Yay!

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:3832
@@ +3831,3 @@
+      auto *GV = dyn_cast<GlobalVariable>(ValueList[ValueID]);
+      if (GV)
+        parseGlobalObjectAttachment(*GV, ArrayRef<uint64_t>(Record).slice(1));
----------------
if (auto *GV = ...) ?


http://reviews.llvm.org/D20074