[PATCH] D20038: Make CodeView TypeIterator generic so that it can iterate symbols too

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: include/llvm/DebugInfo/CodeView/RecordIterator.h:20
@@ +19,3 @@
+// A const input iterator interface to the CodeView record stream.
+template <typename Kind> class RecordIterator {
+private:
----------------
Maybe call the template parameter RecordKind or KindType so you can call the Record field `Kind` instead of `Type`?

================
Comment at: include/llvm/DebugInfo/CodeView/RecordIterator.h:113-114
@@ +112,4 @@
+}
+}
+}
+
----------------
// end namespace codeview / llvm?

================
Comment at: include/llvm/DebugInfo/CodeView/TypeRecord.h:275
@@ -274,3 +274,3 @@
 
 // A CodeView type stream is a sequence of TypeRecords. Records larger than
 // 65536 must chain on to a second record. Each TypeRecord is followed by one of
----------------
Once upon a type, `TypeRecord` was an actual class. With TypeRecordPrefix gone, the last vestiges of it are gone. Can you replace TypeRecord with "type record" here?


http://reviews.llvm.org/D20038