[PATCH] D19904: XRay: Add entry and exit sleds

Balaram Makam via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 09:56:35 PDT 2016

bmakam added inline comments.

Comment at: lib/Target/X86/X86MCInstLower.cpp:1082
@@ +1081,3 @@
+  //   jmp .tmpN
+  //   # 9 bytes worth of noops
+  // .tmpN
Could you please expand on why you need 9 bytes of noops here? I am not quite familiar with x86_64 but was under the impression that on x86_64 the jmp instruction is 1 byte for opcode and 4 bytes for signed relative displacement, so shouldn't 5 bytes worth of nops be sufficient?


More information about the llvm-commits mailing list