[PATCH] D19873: [mips][micromips] Make getPointerRegClass() result depend on the instruction.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 06:30:37 PDT 2016


dsanders added inline comments.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1086
@@ +1085,3 @@
+  template <unsigned Bits> bool isMemWithUimmWordAlignedOffsetGP() const {
+    return isMem() && isConstantMemOff() && isUInt<Bits>(getConstantMemOff())
+      && (getConstantMemOff() % 4 == 0) && getMemBase()->isRegIdx()
----------------
sdardis wrote:
> isInt instead of isUInt. LWGP takes a signed offset, not an unsigned one.
Well spotted. That's remarkably subtle in the docs and it's the opposite of the near-identical LWSP that's next to it.


http://reviews.llvm.org/D19873





More information about the llvm-commits mailing list