[llvm] r268712 - [TableGen] Fix a memory leak when creating SwitchOpcodeMatchers.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 23:56:15 PDT 2016


Author: ctopper
Date: Fri May  6 01:56:14 2016
New Revision: 268712

URL: http://llvm.org/viewvc/llvm-project?rev=268712&view=rev
Log:
[TableGen] Fix a memory leak when creating SwitchOpcodeMatchers.

Modified:
    llvm/trunk/utils/TableGen/DAGISelMatcherOpt.cpp

Modified: llvm/trunk/utils/TableGen/DAGISelMatcherOpt.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/DAGISelMatcherOpt.cpp?rev=268712&r1=268711&r2=268712&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/DAGISelMatcherOpt.cpp (original)
+++ llvm/trunk/utils/TableGen/DAGISelMatcherOpt.cpp Fri May  6 01:56:14 2016
@@ -383,7 +383,8 @@ static void FactorNodes(std::unique_ptr<
       CheckOpcodeMatcher *COM = cast<CheckOpcodeMatcher>(NewOptionsToMatch[i]);
       assert(Opcodes.insert(COM->getOpcode().getEnumName()).second &&
              "Duplicate opcodes not factored?");
-      Cases.push_back(std::make_pair(&COM->getOpcode(), COM->getNext()));
+      Cases.push_back(std::make_pair(&COM->getOpcode(), COM->takeNext()));
+      delete COM;
     }
     
     MatcherPtr.reset(new SwitchOpcodeMatcher(Cases));




More information about the llvm-commits mailing list