[PATCH] D18865: [asan] add option to set shadow mapping offset

Aaron Carroll via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 19:07:19 PDT 2016


> On May 4, 2016, at 18:34, Ryan Govostes <rgovostes+git at gmail.com> wrote:
> 
> rgov added a comment.
> 
> Not sure if I can re-open the revision. We got a failure on one of the PS4 buildbots:
> 
>  opt: for the -asan-mapping-offset option: Cannot find option named '0xdeadbeef'!
>  FileCheck error: '-' is empty.
> 
> 
> http://reviews.llvm.org/D18865

The problem was using uint64_t for the option type. On Darwin, this is typedef’d to unsigned long long, for which there is an option parser. On Linux, it’s an unsigned long, and there’s no option parser specialization for that, so we get the default enumeration parser.

Fixing by s/uint64_t/unsigned long long/



More information about the llvm-commits mailing list