[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 16:34:34 PDT 2016


MatzeB added a comment.

I just filed http://llvm.org/PR27659 which we should fix in the long term.

For the short term we do indeed need code like the one found in SplitKit::computeLastSplitPoint(). However we should not need to insert the whole of SplitKit just to determine a good insertion point. I think what we should do instead is:

- Factor the code in SplitKit::computeLastSplitPoint out into an independent function which is then used by SplitKit and the InlineSpiller.
- I don't know how many queries the InlineSpiller will make, but maybe we can live without the caching logic in SplitKit here? Otherwise the best action would be to pull that out into a custom class as well which is then used by SplitKit and the InlinerSpiller.


Repository:
  rL LLVM

http://reviews.llvm.org/D19884





More information about the llvm-commits mailing list