[PATCH] D19564: Update Debug Intrinsics in RewriteUsesOfClonedInstructions in LoopRotation

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 15:46:55 PDT 2016


nah, I'll leave it to you

On Thu, May 5, 2016 at 2:15 PM, Adrian Prantl via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> aprantl accepted this revision.
> aprantl added a reviewer: aprantl.
> aprantl added a comment.
> This revision is now accepted and ready to land.
>
> Small nitpick, otherwise this looks good now unless David has remaining
> concerns.
>
> thanks!
>
>
> ================
> Comment at: lib/Transforms/Scalar/LoopRotation.cpp:124
> @@ +123,3 @@
> +          Use &U = *UI++;
> +          if (DbgInfoIntrinsic *UserInst =
> dyn_cast<DbgInfoIntrinsic>(U.getUser())) {
> +            BasicBlock *UserBB = UserInst->getParent();
> ----------------
> if !() continue; ?
>
>
>
> http://reviews.llvm.org/D19564
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160505/0ed25148/attachment.html>


More information about the llvm-commits mailing list