[PATCH] SDAG: Remove OPC_MarkGlueResults and associated logic. NFC

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 15:43:55 PDT 2016


Pete Cooper <peter_cooper at apple.com> writes:
>> On May 5, 2016, at 2:44 PM, Justin Bogner via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> 
>> Ping.
>> 
>> Justin Bogner <mail at justinbogner.com> writes:
>>> I noticed a funny thing while trying to refactor some parts of
>>> SelectionDAG to avoid undefined behaviour on my way to fixing
>>> llvm.org/PR26808.
>>> 
>>> The OPC_MarkGlueResults node isn't ever generated for any of the
>>> backends. This in turn means that the very questionable use of
>>> GlueResultNodesMatched where we peer into deleted SDNodes isn't ever
>>> hit, which is nice since that would be horrible undefined behaviour.
>>> 
>>> The attached patch just removes the opcode and related baggage. Sound
>>> good?
>> 
>> Anyone have any reason not to do this? It's provably correct.
> Provably correct is the best kind of correct.
>
> LGTM.

Thanks. r268692.


More information about the llvm-commits mailing list