[PATCH] D19564: Update Debug Intrinsics in RewriteUsesOfClonedInstructions in LoopRotation

Thomas Jablin via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 13:22:52 PDT 2016


tjablin updated this revision to Diff 56336.
tjablin added a comment.

Address Adrian's concerns:

- Add period to end of comment.
- Use auto where possible.
- Range-based for is not possible, since updating the use will also invalidate the underlying iterator.
- Switch to dyn_cast, although I'm pretty sure that only DbgIntrinsics use MetadataAsValue currently.


http://reviews.llvm.org/D19564

Files:
  lib/Transforms/Scalar/LoopRotation.cpp
  test/Transforms/LoopRotate/dbgvalue.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19564.56336.patch
Type: text/x-patch
Size: 4386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160505/508f4b3a/attachment.bin>


More information about the llvm-commits mailing list