[PATCH] D19986: Refactor the Verifier so it can diagnose IR validation errors and debug info metadata errors separately. (NFC)

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 11:11:59 PDT 2016


aprantl created this revision.
aprantl added reviewers: joker.eph, dexonsmith.
aprantl added a subscriber: llvm-commits.

This patch refactors the Verifier so it can diagnose IR validation errors and debug info metadata errors separately.
The motivation behind this change is that broken (or outdated) debug info can be "recovered" from by stripping the debug info.

The problem I'm trying to solve with this sequence of patches is that historically we've done a really bad job at verifying debug info. We want to be able to make the verifier stricter without having to worry about breaking bitcode compatibility with existing producers. For example, we don't necessarily want IR produced by an older version of clang to be rejected by an LTO link just because of malformed debug info, and rather provide an option to strip it. Note that merely outdated (but well-formed) debug info would continue to be auto-upgraded in this scenario.

rdar://problem/25818489

http://reviews.llvm.org/D19986

Files:
  lib/IR/Verifier.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19986.56313.patch
Type: text/x-patch
Size: 26063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160505/28b9ee08/attachment-0001.bin>


More information about the llvm-commits mailing list