[PATCH] D19894: AMDGPU: Fix not counting shader input registers

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 10:37:27 PDT 2016


nhaehnle added a comment.

I'm not sure I understand the design of addArgUserReg. Is the CurReg parameter supposed to be correct or not? If yes, why is there a separate return value? If not, why is it there in the first place? It also seems like the alignment of SGPRs could just be done by a numerical rounding up instead of a loop.


http://reviews.llvm.org/D19894





More information about the llvm-commits mailing list