[PATCH] D19556: [ThinLTO] Emit individual index files for distributed backends

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 10:33:16 PDT 2016


joker.eph added a comment.

For the MSAN issue:


================
Comment at: llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp:347
@@ +346,3 @@
+                                        : IndexSummariesBack->second.end();
+      }
+    }
----------------
Here if `Writer.Index.begin() == Writer.Index.end()` we end up with `IndexGVSummariesIter` being uninitialized.

================
Comment at: llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp:363
@@ +362,3 @@
+      } else {
+        ++IndexGVSummariesIter;
+        if (IndexGVSummariesIter == IndexSummariesIter->second.end() &&
----------------
Here we don't check for the same conditions as in the ctor.


Repository:
  rL LLVM

http://reviews.llvm.org/D19556





More information about the llvm-commits mailing list