[PATCH] D19926: Simplify CFG before assigning discriminator.

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 09:18:44 PDT 2016


The test case oneline.ll I just updated is actually a motivating
example: simplifycfg reduced the BB number from 5 to 4, thus there
will be one less discriminator assigned.

Dehao

On Thu, May 5, 2016 at 9:12 AM, Diego Novillo <dnovillo at google.com> wrote:
> OK,  sure.  What I meant is a testcase that motivates this change.
>
>
> On Thu, May 5, 2016, 11:40 Dehao Chen <danielcdh at gmail.com> wrote:
>>
>> This patch works the other way: it reduces # of discriminators
>> assigned because CFGs are simplified. I don't think we can build such
>> a testcase unless simplifycfg complicates the CFG.
>>
>> Thanks,
>> Dehao
>>
>> On Thu, May 5, 2016 at 5:16 AM, Diego Novillo <dnovillo at google.com> wrote:
>> > dnovillo added a comment.
>> >
>> > Would it be possible to get a test case where we miss discriminator
>> > placement if simplifycfg doesn't run beforehand?
>> >
>> >
>> > http://reviews.llvm.org/D19926
>> >
>> >
>> >


More information about the llvm-commits mailing list