[PATCH] D19954: ELF: Undefine all symbols, not just those that we expect to be defined.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 07:43:29 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

This will allow an undefined in a .bc file as long as lto optimizes it out, no?
I guess that is OK,  but would be nice to add a comment about it.


================
Comment at: test/ELF/lto/parallel-internalize.ll:4
@@ +3,3 @@
+; RUN: ld.lld -m elf_x86_64 --lto-jobs=2 -save-temps -o %t %t.bc -e foo --lto-O0
+; RUN: llvm-nm %t0.lto.o | FileCheck --check-prefix=CHECK0 %s
+; RUN: llvm-nm %t1.lto.o | FileCheck --check-prefix=CHECK1 %s
----------------
Please also check the symbols in the final binary.

We should have only foo, right? Bar should still be internalized and when splitting it will be marked hidden.


http://reviews.llvm.org/D19954





More information about the llvm-commits mailing list