[PATCH] D19929: Fix Mips Parser error reporting

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 07:09:57 PDT 2016


niravd marked 2 inline comments as done.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:4884
@@ -4883,2 +4883,3 @@
 
+//FIXME: These two functions should both either eat or not eat
 bool MipsAsmParser::reportParseError(Twine ErrorMsg) {
----------------
dsanders wrote:
> If they're going to have the same name then I agree that they should be consistent in behaviour. From their usage it looks like we ought to have both behaviours available so I think it's best to rename one of them. We should leave that for another patch though.
Either that or merge them into a single. Regardless, I've added a bit more text to be a bit clearer.


http://reviews.llvm.org/D19929





More information about the llvm-commits mailing list