[llvm] r268588 - Revert "[asan] add option to set shadow mapping offset"

[Ryan Govostes via llvm-commits]

Author: rgov
Date: Wed May  4 20:27:04 2016
New Revision: 268588

URL: http://llvm.org/viewvc/llvm-project?rev=268588&view=rev
Log:
Revert "[asan] add option to set shadow mapping offset"

This reverts commit ba89768f97b1d4326acb5e33c14eb23a05c7bea7.

Removed:
    llvm/trunk/test/Instrumentation/AddressSanitizer/scale-offset.ll
Modified:
    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp

Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=268588&r1=268587&r2=268588&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Wed May  4 20:27:04 2016
@@ -204,13 +204,10 @@ static cl::opt<bool> ClSkipPromotableAll
 
 // These flags allow to change the shadow mapping.
 // The shadow mapping looks like
-//    Shadow = (Mem >> scale) + offset
+//    Shadow = (Mem >> scale) + (1 << offset_log)
 static cl::opt<int> ClMappingScale("asan-mapping-scale",
                                    cl::desc("scale of asan shadow mapping"),
                                    cl::Hidden, cl::init(0));
-static cl::opt<uint64_t> ClMappingOffset("asan-mapping-offset",
-                                   cl::desc("offset of asan shadow mapping [EXPERIMENTAL]"),
-                                   cl::Hidden, cl::init(0));
 
 // Optimization flags. Not user visible, used mostly for testing
 // and benchmarking the tool.
@@ -407,14 +404,10 @@ static ShadowMapping getShadowMapping(Tr
   }
 
   Mapping.Scale = kDefaultShadowScale;
-  if (ClMappingScale.getNumOccurrences() > 0) {
+  if (ClMappingScale) {
     Mapping.Scale = ClMappingScale;
   }
 
-  if (ClMappingOffset.getNumOccurrences() > 0) {
-    Mapping.Offset = ClMappingOffset;
-  }
-
   // OR-ing shadow offset if more efficient (at least on x86) if the offset
   // is a power of two, but on ppc64 we have to use add since the shadow
   // offset is not necessary 1/8-th of the address space.  On SystemZ,

Removed: llvm/trunk/test/Instrumentation/AddressSanitizer/scale-offset.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/AddressSanitizer/scale-offset.ll?rev=268587&view=auto
==============================================================================
--- llvm/trunk/test/Instrumentation/AddressSanitizer/scale-offset.ll (original)
+++ llvm/trunk/test/Instrumentation/AddressSanitizer/scale-offset.ll (removed)
@@ -1,39 +0,0 @@
-; Test that the scale (-asan-mapping-scale) and offset (-asan-mapping-offset) command-line options work as expected
-;
-; RUN: opt < %s -asan -asan-module -asan-mapping-offset 0xdeadbeef -S | FileCheck --check-prefix=CHECK-OFFSET %s
-; RUN: opt < %s -asan -asan-module -asan-mapping-scale 1 -S | FileCheck --check-prefix=CHECK-SCALE %s
-; RUN: opt < %s -asan -asan-module -asan-mapping-offset 0xc0ffee -asan-mapping-scale 0 -S | FileCheck --check-prefix=CHECK-BOTH %s
-target triple = "x86_64-unknown-linux-gnu"
-
-define i32 @read_offset(i32* %a) sanitize_address {
-entry:
-  %tmp1 = load i32, i32* %a, align 4
-  ret i32 %tmp1
-}
-; CHECK-OFFSET-LABEL: @read_offset
-; CHECK-OFFSET-NOT: ret
-; CHECK-OFFSET: lshr {{.*}} 3
-; CHECK-OFFSET-NEXT: add{{.*}}3735928559
-; CHECK-OFFSET: ret
-
-define i32 @read_scale(i32* %a) sanitize_address {
-entry:
-  %tmp1 = load i32, i32* %a, align 4
-  ret i32 %tmp1
-}
-; CHECK-SCALE-LABEL: @read_scale
-; CHECK-SCALE-NOT: ret
-; CHECK-SCALE: lshr {{.*}} 1
-; CHECK-SCALE-NEXT: add{{.*}}
-; CHECK-SCALE: ret
-
-define i32 @read_both(i32* %a) sanitize_address {
-entry:
-  %tmp1 = load i32, i32* %a, align 4
-  ret i32 %tmp1
-}
-; CHECK-BOTH-LABEL: @read_both
-; CHECK-BOTH-NOT: ret
-; CHECK-BOTH: lshr {{.*}} 0
-; CHECK-BOTH-NEXT: add{{.*}}12648430
-; CHECK-BOTH: ret