[PATCH] D19556: [ThinLTO] Emit individual index files for distributed backends

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:745
@@ +744,3 @@
+                          ImportLists, ModuleToSummariesForIndex);
+}
+
----------------
joker.eph wrote:
> tejohnson wrote:
> > joker.eph wrote:
> > > I am wondering if this need to sit on the `ThinLTOCodeGenerator` though: it does not use any member, does it?
> > You're right it doesn't. It is invoked from llvm-lto - would it be better to just create a global function outside the class but still in ThinLTOCodeGenerator.h/cpp (in the llvm namespace)? 
> I'm not totally sure what is "the right thing to do", maybe just turning it into a static method in the class would be enough for now? 
> 
> I don't have a strong opinion on this, I figured I'll just mention it.
> 
> Initially I had this class only having `addModule` and `run`. The individual method I added were here to support breaking down testing of all of what's going on in `run()`. It is slightly slipping here, but we'll refactor all of that later, hopefully not in too long.
I think using a static class member makes the most sense for now, will do that.


http://reviews.llvm.org/D19556