[PATCH] D19556: [ThinLTO] Emit individual index files for distributed backends

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 14:12:07 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:745
@@ +744,3 @@
+                          ImportLists, ModuleToSummariesForIndex);
+}
+
----------------
joker.eph wrote:
> I am wondering if this need to sit on the `ThinLTOCodeGenerator` though: it does not use any member, does it?
You're right it doesn't. It is invoked from llvm-lto - would it be better to just create a global function outside the class but still in ThinLTOCodeGenerator.h/cpp (in the llvm namespace)? 


http://reviews.llvm.org/D19556





More information about the llvm-commits mailing list