[LNT] r268414 - `runtests test-suite` requires -cc or lnt is crashing badly, display a nice message instead.

[Mehdi Amini via llvm-commits]

Sure!

r268546

-- 
Mehdi


> On May 4, 2016, at 5:22 AM, James Molloy <james at jamesmolloy.co.uk> wrote:
> 
> Thanks Mehdi!
> 
> There's a fairly decent test suite for the test_suite.py file in test/runtest/test_suite.py. Would you mind please adding this as a testcase there?
> 
> Cheers,
> 
> James
> 
> On Tue, 3 May 2016 at 23:21 Chris Matthews via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Good one!
> 
> > On May 3, 2016, at 11:17 AM, Mehdi Amini via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> >
> > Author: mehdi_amini
> > Date: Tue May  3 13:17:39 2016
> > New Revision: 268414
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=268414&view=rev <http://llvm.org/viewvc/llvm-project?rev=268414&view=rev>
> > Log:
> > `runtests test-suite` requires -cc or lnt is crashing badly, display a nice message instead.
> >
> > From: Mehdi Amini <mehdi.amini at apple.com <mailto:mehdi.amini at apple.com>>
> >
> > Modified:
> >    lnt/trunk/lnt/tests/test_suite.py
> >
> > Modified: lnt/trunk/lnt/tests/test_suite.py
> > URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/test_suite.py?rev=268414&r1=268413&r2=268414&view=diff <http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/test_suite.py?rev=268414&r1=268413&r2=268414&view=diff>
> > ==============================================================================
> > --- lnt/trunk/lnt/tests/test_suite.py (original)
> > +++ lnt/trunk/lnt/tests/test_suite.py Tue May  3 13:17:39 2016
> > @@ -240,6 +240,9 @@ class TestSuiteTest(BuiltinTest):
> >         if self.opts.sandbox_path is None:
> >             parser.error('--sandbox is required')
> >
> > +        if self.opts.cc <http://self.opts.cc/> is None:
> > +            parser.error('--cc is required')
> > +
> >         # Option validation.
> >         opts.cc = resolve_command_path(opts.cc)
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160504/88ef2a4b/attachment.html>