[PATCH] D19923: [NFC] Run Windows-specific code only on Windows platform

Eugene via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 09:50:18 PDT 2016


kevgs added inline comments.

================
Comment at: lib/Target/X86/X86TargetMachine.cpp:43
@@ -41,2 +42,3 @@
   initializeWinEHStatePassPass(PR);
+#endif
 }
----------------
probinson wrote:
> Isn't this a Windows-target thing?  You've made it a Windows-host thing.
I'm building clang on Linux, running like this clang++ foo.cc and this code executes. My thoughts is that clang++ frontend isn't meant to generate Windows code because clang-cl is meant for this puprose.

Should clang++ be able to generate Windows code?


http://reviews.llvm.org/D19923





More information about the llvm-commits mailing list