[PATCH] D19718: [mips] Correct the ordering of HI/LO pairs in the relocation table.

[Simon Dardis via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with nits addressed.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp:86-88
@@ +85,5 @@
+enum FindBestPredicateResult {
+  FindBest_NoMatch = 0, ///< The current element is not a match.
+  FindBest_Match,       ///< The current element is a match but better ones are possible.
+  FindBest_PerfectMatch, ///< The current element is an unbeatable match.
+};
----------------
Nit: Align the top two comments lines with the bottom line.

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp:156
@@ +155,3 @@
+/// A relocation matches if:
+/// - It's type that of a corresponding low part. This is provided in
+///   MatchingType for efficiency.
----------------
Nit: The first sentence here is a somewhat fragmented. I assume you're saying "It's type matches that of a corresponding low part".

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp:178
@@ +177,3 @@
+  return FindBest_NoMatch;
+};
+
----------------
warning: extra ';' [-Wpendantic]


http://reviews.llvm.org/D19718