[PATCH] D19912: [SimplifyCFG] isSafeToSpeculateStore now ignores debug info

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 06:37:36 PDT 2016


mcrosier added a subscriber: mcrosier.
mcrosier added a comment.

Minor comments on the test, but the change itself LGTM.


================
Comment at: test/Transforms/SimplifyCFG/PR27615-simplify-cond-br.ll:1
@@ +1,2 @@
+; RUN: opt -S -simplifycfg -strip-debug < %s | FileCheck --check-prefix CHECK-NO-DBG %s
+; RUN: opt -S -simplifycfg < %s | FileCheck --check-prefix CHECK-DBG %s
----------------
If the expectation is that the output should be exactly the same with and without debug, I'd suggest dropping the prefixes from both RUN commands and have only a single version of the check.  I.e.,

  ; CHECK: select i1 %or.cond, i32 -1, i32 5
  ; CHECK-NOT: bb1:


http://reviews.llvm.org/D19912





More information about the llvm-commits mailing list