[PATCH] D19892: Remove LLVM_ENABLE_TIMESTAMPS

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Sounds like a plan!


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:371
@@ -370,3 +370,3 @@
     # link.exe /incremental requires a timestamp in the .obj file.  clang-cl
-    # has the flag /Brepro to force deterministic binaries, so pass that when
-    # LLVM_ENABLE_TIMESTAMPS is turned off.
+    # has the flag /Brepro to force deterministic binaries we should pass that
+    # whenever you're building with clang.
----------------
Looks like a run-on. Maybe end the sentence and start a new one.

================
Comment at: cmake/modules/HandleLLVMOptions.cmake:391
@@ -392,2 +390,3 @@
           ${shared_index} GREATER -1)
-        message(FATAL_ERROR "LLVM_ENABLE_TIMESTAMPS not compatible with /INCREMENTAL linking")
+        message(WARNING "/Brepro not compatible with /INCREMENTAL linking - builds will be non-deterministic")
+      else()
----------------
We can warn and see if people complain, but I think people using the incremental linker have no expectation of getting a reproducible build artifact. We want /Brepro when there is no incremental linking, though, so this change is good.


http://reviews.llvm.org/D19892