[PATCH] D19351: ELF: Add initial ThinLTO support.

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.

In http://reviews.llvm.org/D19351#420587, @pcc wrote:

> > The proper solution should be in my opinion to have a "LTOCodeGenerator" (and/or a "ThinLTOCodeGenerator") that exposes an appropriate interface to the linker, that would be shared by lld, gold, etc.
>
>
> Maybe, but I'm not sure that we can know what the right interface should be without working implementations in multiple linkers.


There *is* an LTO implementation that is working in multiple linker through libLTO (and gold that went with a dedicated plugin).

> 

> 

> > I'll break lld and won't try to fix it

> 

> 

> That doesn't really seem reasonable to me. We all have a responsibility to keep the bots green.


That seems reasonable, but the conclusion on my side is that I then disagree with implementing ThinLTO in lld at all at this point as it is adding duplicating code that should not be there in the first place, and will just prevent progress in LLVM (the gold-plugin is already "technical debt")


http://reviews.llvm.org/D19351