[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

[Eric Christopher via llvm-commits]

echristo added inline comments.

================
Comment at: lib/CodeGen/InlineSpiller.cpp:1397
@@ +1396,3 @@
+    LiveInterval &OrigLI = LIS.getInterval(OrigReg);
+    SA->analyze(&OrigLI, true);
+
----------------
Needs a comment of why you want to skip the analysis here.

================
Comment at: test/CodeGen/X86/hoist-spill-lpad.ll:3-5
@@ +2,5 @@
+
+; PR27612. When spill is hoisted to a BB with landingpad successor, and if
+; the VNI of the spill reg lives into the landingpad successor, the
+; spill should be inserted before the call which may throw exception.
+;
----------------
I think this can be reworded in a more general way such that it's clear if this breaks what's going on. If I understand correctly we need to use the split point as the insert location because the spill reg could be live through the next block?


Repository:
  rL LLVM

http://reviews.llvm.org/D19884