[PATCH] D19125: Enable __float128 on X86 and SystemZ

[Eric Christopher via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Couple of inline comments, but this works for me provided answers are OK to the questions inline.

-eric


================
Comment at: lib/Basic/Targets.cpp:437
@@ -436,1 +436,3 @@
       break;
+    case llvm::Triple::x86:
+    case llvm::Triple::x86_64:
----------------
nemanjai wrote:
> I am not sure this is the right way to do this, but it seems to encapsulate the requested semantics (i.e. Linux/i386...).
Seems ok. What happened to the ppc64 lines? (I don't particularly like this solution, but it's fine for now)

================
Comment at: test/Sema/128bitfloat.cpp:4
@@ -3,1 +3,3 @@
 
+#ifdef __x86_64__
+__float128 f;
----------------
nemanjai wrote:
> I think it'll be better if I change this to
>   #ifdef __FLOAT228__
Modulo typo, but I think that works yeah.


Repository:
  rL LLVM

http://reviews.llvm.org/D19125