[llvm] r268305 - Don't try to create thin bsd archives.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 12:43:06 PDT 2016


ok, thanks.

Cheers,
Rafael


On 3 May 2016 at 15:41, Davide Italiano <davide at freebsd.org> wrote:
> On Tue, May 3, 2016 at 11:58 AM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>> Not sure the parenthesis are needed given the string is always true.
>>
>
> Makes sense. I tried to revert, then noticed gcc warns on this one, so
> I'd leave it as is.
>
>
>> On May 3, 2016 3:38 AM, "Davide Italiano" <davide at freebsd.org> wrote:
>>>
>>> On Mon, May 2, 2016 at 2:06 PM, Rafael Espindola via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>> > Author: rafael
>>> > Date: Mon May  2 16:06:57 2016
>>> > New Revision: 268305
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=268305&view=rev
>>> > Log:
>>> > Don't try to create thin bsd archives.
>>> >
>>> > Not such variant has been specified yet.
>>> >
>>> > Modified:
>>> >     llvm/trunk/lib/Object/ArchiveWriter.cpp
>>> >     llvm/trunk/test/Object/archive-format.test
>>> >     llvm/trunk/tools/llvm-ar/llvm-ar.cpp
>>> >
>>> > Modified: llvm/trunk/lib/Object/ArchiveWriter.cpp
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=268305&r1=268304&r2=268305&view=diff
>>> >
>>> > ==============================================================================
>>> > --- llvm/trunk/lib/Object/ArchiveWriter.cpp (original)
>>> > +++ llvm/trunk/lib/Object/ArchiveWriter.cpp Mon May  2 16:06:57 2016
>>> > @@ -308,6 +308,9 @@ llvm::writeArchive(StringRef ArcName,
>>> >                     std::vector<NewArchiveIterator> &NewMembers,
>>> >                     bool WriteSymtab, object::Archive::Kind Kind,
>>> >                     bool Deterministic, bool Thin) {
>>> > +  assert(!Thin ||
>>> > +         Kind == object::Archive::K_GNU &&
>>> > +             "Only the gnu format has a thin mode");
>>> >    SmallString<128> TmpArchive;
>>> >    int TmpArchiveFD;
>>>
>>> I think this lacks a pair of ().
>>> I went ahead and tried to fix in r268367. Hope this is what you
>>> intended to assert.
>>>
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare


More information about the llvm-commits mailing list