[llvm] r268421 - Revert 268409 due to missing comment.

Jack Liu via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 12:15:02 PDT 2016


Author: liu12295
Date: Tue May  3 14:15:02 2016
New Revision: 268421

URL: http://llvm.org/viewvc/llvm-project?rev=268421&view=rev
Log:
Revert 268409 due to missing comment.

Modified:
    llvm/trunk/lib/Transforms/Scalar/SROA.cpp
    llvm/trunk/test/Transforms/SROA/address-spaces.ll

Modified: llvm/trunk/lib/Transforms/Scalar/SROA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SROA.cpp?rev=268421&r1=268420&r2=268421&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/SROA.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/SROA.cpp Tue May  3 14:15:02 2016
@@ -1635,10 +1635,8 @@ static bool canConvertValue(const DataLa
   OldTy = OldTy->getScalarType();
   NewTy = NewTy->getScalarType();
   if (NewTy->isPointerTy() || OldTy->isPointerTy()) {
-    if (NewTy->isPointerTy() && OldTy->isPointerTy()) {
-      return cast<PointerType>(NewTy)->getPointerAddressSpace() ==
-        cast<PointerType>(OldTy)->getPointerAddressSpace();
-    }
+    if (NewTy->isPointerTy() && OldTy->isPointerTy())
+      return true;
     if (NewTy->isIntegerTy() || OldTy->isIntegerTy())
       return true;
     return false;

Modified: llvm/trunk/test/Transforms/SROA/address-spaces.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/SROA/address-spaces.ll?rev=268421&r1=268420&r2=268421&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/SROA/address-spaces.ll (original)
+++ llvm/trunk/test/Transforms/SROA/address-spaces.ll Tue May  3 14:15:02 2016
@@ -52,7 +52,7 @@ define void @test_address_space_0_1(<2 x
 
 %struct.struct_test_27.0.13 = type { i32, float, i64, i8, [4 x i32] }
 
-; Function Attrs: nounwind
+; Function Attrs:  nounwind
 define void @copy_struct([5 x i64] %in.coerce) {
 ; CHECK-LABEL: @copy_struct(
 ; CHECK-NOT: memcpy
@@ -66,20 +66,3 @@ for.end:
   ret void
 }
  
-%union.anon = type { i32* }
-
- at g = common global i32 0, align 4
- at l = common addrspace(3) global i32 0, align 4
-
-; Make sure an illegal bitcast isn't introduced
-define void @pr27557() {
-; CHECK-LABEL: @pr27557(
-; CHECK: %[[CAST:.*]] = bitcast i32** {{.*}} to i32 addrspace(3)**
-; CHECK: store i32 addrspace(3)* @l, i32 addrspace(3)** %[[CAST]]
-  %1 = alloca %union.anon, align 8
-  %2 = bitcast %union.anon* %1 to i32**
-  store i32* @g, i32** %2, align 8
-  %3 = bitcast %union.anon* %1 to i32 addrspace(3)**
-  store i32 addrspace(3)* @l, i32 addrspace(3)** %3, align 8
-  ret void
-}




More information about the llvm-commits mailing list