[PATCH] D19875: [sanitizer] Move stat/__xstat to the common interceptors

Qin Zhao via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 12:16:53 PDT 2016


zhaoqin added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5527
@@ +5526,3 @@
+  int res = REAL(stat)(path, buf);
+  if (!res)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, buf, __sanitizer::struct_stat_sz);
----------------
should I add flags check here too?
I feel that the write cannot be skipped for correctness, e.g., msan mark buffer as defined.


Repository:
  rL LLVM

http://reviews.llvm.org/D19875





More information about the llvm-commits mailing list