[PATCH] D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes

[Chad Rosier via llvm-commits]

mcrosier added a comment.

-Please refactor the optsize tests into a single file (e.g., unroll-optsize.ll).  If you factored all the test into a single file that would be even better.  We want to minimize the number of times opt is invoked.
-Please add a test case for minsize.  In this case we don't want to unroll the loop, if I'm not mistaken.

How are we handling -O1?  The clang patch http://reviews.llvm.org/D19827 will have a functional change at this optimization level, if I'm not mistaken.


================
Comment at: test/Transforms/LoopUnroll/unroll-optnone.ll:19
@@ +18,3 @@
+}
+
+; CHECK:      phi
----------------
Please add a CHECK-LABEL directive.  I.e.,

  CHECK-LABEL: @unroll_optnone

================
Comment at: test/Transforms/LoopUnroll/unroll-optsize1.ll:19
@@ +18,3 @@
+}
+
+; CHECK:      phi
----------------
Please add a CHECK-LABEL directive.

================
Comment at: test/Transforms/LoopUnroll/unroll-optsize2.ll:18
@@ +17,3 @@
+}
+
+; CHECK:      phi
----------------
Please add a CHECK-LABEL directive.


Repository:
  rL LLVM

http://reviews.llvm.org/D19870