[llvm] r268219 - [SystemZ] Temporarily disable codegen test int-add-12.ll.

[Justin Bogner via llvm-commits]

Jonas Paulsson via llvm-commits <llvm-commits at lists.llvm.org> writes:
> Author: jonpa
> Date: Mon May  2 05:42:47 2016
> New Revision: 268219
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268219&view=rev
> Log:
> [SystemZ] Temporarily disable codegen test int-add-12.ll.
>
> This checks for AGSI transformation, which is temporarily disabled.
>
> Modified:
>     llvm/trunk/test/CodeGen/SystemZ/int-add-12.ll
>
> Modified: llvm/trunk/test/CodeGen/SystemZ/int-add-12.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/SystemZ/int-add-12.ll?rev=268219&r1=268218&r2=268219&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/SystemZ/int-add-12.ll (original)
> +++ llvm/trunk/test/CodeGen/SystemZ/int-add-12.ll Mon May  2 05:42:47 2016
> @@ -130,7 +130,7 @@ define void @f10(i64 %base, i64 %index)
>  ; Check that adding 127 to a spilled value can use AGSI.
>  define void @f11(i64 *%ptr, i32 %sel) {
>  ; CHECK-LABEL: f11:
> -; CHECK: agsi {{[0-9]+}}(%r15), 127
> +; _CHECK: agsi {{[0-9]+}}(%r15), 127

Please don't do this in this way. It looks like an error and is
confusing for anyone who reads the test.

Personally, I prefer to just delete the line until the transformation in
question is back in place - it's easy to find this from the version
control history. If you really want this here as a reminder, it's best
to mark it with something obvious, like TODO:, FIXME:, or DISABLED:.

>  ; CHECK: br %r14
>  entry:
>    %val0 = load volatile i64 , i64 *%ptr
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits