[PATCH] D19840: Parse and dump PDB TPI Stream

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: include/llvm/DebugInfo/PDB/Raw/TpiStream.h:1
@@ +1,2 @@
+//===- TpiStream.h - PDB Tpi Stream (Stream 2) Access -----------*- C++ -*-===//
+//
----------------
Maybe this? "PDB Type Information (TPI) stream (stream 2) access"

I was wondering what the mystery "P" was.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/TpiStream.h:24
@@ +23,3 @@
+
+class TpiStream {
+  struct HeaderInfo;
----------------
Doc comments here, with the acronym expansion as well would be good.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/TpiStream.h:23
@@ +22,3 @@
+typedef uint32_t (*HashFunctionType)(uint8_t *, uint32_t);
+
+class TpiStream {
----------------
Also, it won't compile on Linux. :)

================
Comment at: lib/DebugInfo/PDB/Raw/TpiStream.cpp:96
@@ +95,3 @@
+    codeview::TypeRecordPrefix Prefix;
+    RecordsReader.readObject(&Prefix);
+    Record.Kind =
----------------
Check for failure here and on the getArrayRef, otherwise there's not much point to std::error_code

================
Comment at: lib/DebugInfo/PDB/Raw/TpiStream.cpp:25
@@ +24,3 @@
+namespace {
+const uint32_t MinTypeIndex = 0x1000;
+
----------------
This is llvm::codeview::TypeIndex::FirstNonSimpleIndex.


http://reviews.llvm.org/D19840