[PATCH] D19781: [ASan] Disable target-specific lowering of string functions.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 13:29:20 PDT 2016


eugenis added a comment.

Do we want this in the other sanitizers? Probably yes, and with the same list of functions.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1785
@@ -1781,1 +1784,3 @@
         }
+        if (CallInst *CI = dyn_cast<CallInst>(&Inst)) {
+          maybeMarkCallNoInline(CI, TLI);
----------------
We typically write single-statement ifs without the braces.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1844
@@ +1843,3 @@
+// as NoBuiltin, which will disable optimization in CodeGen.
+void AddressSanitizer::maybeMarkCallNoInline(CallInst *CI,
+                                             const TargetLibraryInfo *TLI) {
----------------
Did you mean maybeMarkCallNoBuiltin ?



Repository:
  rL LLVM

http://reviews.llvm.org/D19781





More information about the llvm-commits mailing list