[compiler-rt] r267084 - Enable stack-use-after-scope tests.

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 11:43:00 PDT 2016


On 2 May 2016 at 13:15, Evgenii Stepanov <eugeni.stepanov at gmail.com> wrote:
> file+line should be enough. This is not a debug info / demangler test,
> let's not make it more fragile then necessary.

That sounds fine to me. We definitely want to fix the underlying bugs
in FreeBSD (via libcxxrt / elftoolchain) but this test indeed isn't
the place to test those.

One caveat, Dimitry reported that there's another failure due to
__cxa_demangle turning "foo" into "float". In this case FreeBSD's
__cxa_demangle is not sufficiently validating its input, but
__cxa_demangle should not have been called at all.  As __cxa_demangle
also handles type names it will correctly return "float" for input
"f", which is not what's desired here. I've submitted
http://reviews.llvm.org/D19818 for that issue.


More information about the llvm-commits mailing list