[llvm] r268259 - AMDGPU: llvm.SI.fs.constant is a source of divergence

Nicolai Haehnle via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 10:37:02 PDT 2016


Author: nha
Date: Mon May  2 12:37:01 2016
New Revision: 268259

URL: http://llvm.org/viewvc/llvm-project?rev=268259&view=rev
Log:
AMDGPU: llvm.SI.fs.constant is a source of divergence

Summary:
This intrinsic is used to get flat-shaded fragment shader inputs. Those are
uniform across a primitive, but a fragment shader wave may process pixels from
multiple primitives (as indicated by the prim_mask), and so that's where
divergence can arise.

Reviewers: arsenm, tstellarAMD

Subscribers: arsenm, llvm-commits

Differential Revision: http://reviews.llvm.org/D19747

Added:
    llvm/trunk/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll
Modified:
    llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp?rev=268259&r1=268258&r2=268259&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp Mon May  2 12:37:01 2016
@@ -260,6 +260,7 @@ static bool isIntrinsicSourceOfDivergenc
     return false;
   case AMDGPUIntrinsic::SI_tid:
   case AMDGPUIntrinsic::SI_fs_interp:
+  case AMDGPUIntrinsic::SI_fs_constant:
     return true;
   }
 }

Added: llvm/trunk/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll?rev=268259&view=auto
==============================================================================
--- llvm/trunk/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll (added)
+++ llvm/trunk/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll Mon May  2 12:37:01 2016
@@ -0,0 +1,22 @@
+; RUN: opt  -mtriple amdgcn--- -analyze -divergence %s | FileCheck %s
+
+; CHECK-LABEL: 'fs_interp'
+; CHECK: DIVERGENT: %v = call float @llvm.SI.fs.interp(
+define amdgpu_ps void @fs_interp(i32 inreg %prim_mask, <2 x i32> %interp_param) #1 {
+  %v = call float @llvm.SI.fs.interp(i32 0, i32 0, i32 %prim_mask, <2 x i32> %interp_param)
+  store volatile float %v, float addrspace(1)* undef
+  ret void
+}
+
+; CHECK-LABEL: 'fs_constant'
+; CHECK: DIVERGENT: %v = call float @llvm.SI.fs.constant(
+define amdgpu_ps void @fs_constant(i32 inreg %prim_mask, <2 x i32> %interp_param) #1 {
+  %v = call float @llvm.SI.fs.constant(i32 0, i32 0, i32 %prim_mask)
+  store volatile float %v, float addrspace(1)* undef
+  ret void
+}
+
+declare float @llvm.SI.fs.interp(i32, i32, i32, <2 x i32>) #0
+declare float @llvm.SI.fs.constant(i32, i32, i32) #0
+
+attributes #0 = { nounwind readnone }




More information about the llvm-commits mailing list