[PATCH] D19752: ELF: New symbol table design.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 30 19:25:02 PDT 2016


>> And can this be just a plain union?
> All I need is an appropriately sized and aligned char array. That's what `AlignedCharArrayUnion` provides. I never actually access this field as a `SharedSymbol<ELF64LE>` for example (unless of course I'm in a templated function with `ELFT=ELF64LE`). I'm making an assumption here that ELF32* data structures are not larger or more aligned than ELF64* data structures (and the same for LE and BE), but if they somehow are not, that's what the `static_assert`s below are for.

Got it. Please add a comment :-)

I liked the non templated base, but yes, we can discuss that in another patch.

Cheers,
Rafael


More information about the llvm-commits mailing list