[PATCH] D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 14:39:33 PDT 2016


rnk added a subscriber: rnk.
rnk added a comment.

In http://reviews.llvm.org/D17738#367459, @rafael wrote:

> The real stable solution I think is for the IR name to be the final
>  name. No further mangling involved. It will take a lot of work to get
>  there, but we can avoid making the situation worse.


The problem there is that we would have to make the IR symbol renamer not append '.N' when renaming symbols with name collisions. Until then, we need something like this.

I thought we used to have machinery in our assembler for mangling away invalid characters. Did you remove that stuff?


http://reviews.llvm.org/D17738





More information about the llvm-commits mailing list