[PATCH] D19688: Fixes PR27241 by enabling the X86 call frame optimization for 64-bit targets

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 14:25:45 PDT 2016


rnk added a comment.

I'm a little concerned that this will uncover broken unwinders, but we can find out.


================
Comment at: test/CodeGen/X86/movtopush64.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu | FileCheck %s -check-prefix=NORMAL
+; RUN: llc < %s -mtriple=x86_64-windows | FileCheck %s -check-prefix=NOPUSH
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -no-x86-call-frame-opt | FileCheck %s -check-prefix=NOPUSH
----------------
Can you also test that this is disabled on Darwin? You may need to modify the IR to add uwtable attributes, but I think that condition is worth testing.


http://reviews.llvm.org/D19688





More information about the llvm-commits mailing list