[PATCH] D19670: Prepare LLDB Windows builder to be able to run tests

Galina via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 12:26:39 PDT 2016


gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

LGTM with the minor issue.

Thanks

Galina


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:96
@@ -95,2 +95,3 @@
     # borked. FIXME: See buildbot ticket #595 and buildbot ticket #377.
+    clang_exe = sys.path.join(build_dir, 'bin', 'clang.exe')    # ./bin/clang.exe
     f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
----------------
This will use the path separator specific to the buildmaster. Should work for you now, but could introduce issues if we would move buildmaster to, let's say, Windows.

Maybe just hard code the path separator to keep it consistent to the rest of the module?


http://reviews.llvm.org/D19670





More information about the llvm-commits mailing list