[PATCH] D19657: [ASan] Change condition for __builtin_longjmp test.

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 11:03:50 PDT 2016


koriakin added a comment.

In http://reviews.llvm.org/D19657#415594, @koriakin wrote:

> In http://reviews.llvm.org/D19657#415491, @joerg wrote:
>
> > That's not true. __builtin_longjmp is (currently) supported on X86, PowerPC and ARM. Support for SPARC is currently being worked on.
>
>
> Hm, fair enough.  I'll try to figure out what's wrong with this test on PowerPC, then.


Ugh, clang miscompiles __builtin_setjmp on PowerPC when using internal assembler - there's a stray 0 word in the code section, seems it tries to print an invalid MachineInstr somehow.  I'll fix that.

However, I'm not sure about ARM - the emitted code looks OK to me, and I don't have the hardware to run the test.  Could someone shed some light here?

Btw, what's so useful about __builtin_longjmp/setjmp that someone's implementing it on SPARC?  I thought it was just an ancient exception handling artifact...


Repository:
  rL LLVM

http://reviews.llvm.org/D19657





More information about the llvm-commits mailing list