[PATCH] D19181: Map Attribute in the C API.

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 10:08:41 PDT 2016


deadalnix added a comment.

In http://reviews.llvm.org/D19181#415126, @Wallbraker wrote:

> I kind of prefer the AttributeSet approach, but don't feel to strongly about it.
>
> Creating immutable state objects up front and then reusing it will always be faster then individually setting state on objects. Also AttributeSets better reflect what you see when you read the LLVM bitcode textual representation.


AttributeSet does map all the attribute on a function/call, including return and parameters. There is no way you can create one and reuse it in the general case. Reading your comment, I'm not sure you are familiar with the AttributeSet thing in C++ .


http://reviews.llvm.org/D19181





More information about the llvm-commits mailing list