[PATCH] D19670: Prepare LLDB Windows builder to be able to run tests

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 10:06:23 PDT 2016


zturner created this revision.
zturner added a reviewer: gkistanova.
zturner added a subscriber: llvm-commits.

In a followup patch I want to flip the test flag to True, but I want to do this in preparation first since it is a necessary first step, and if testing doesn't work out and we have to turn them back off, this is still a good change that should stay.

http://reviews.llvm.org/D19670

Files:
  buildbot/osuosl/master/config/builders.py
  zorg/buildbot/builders/LLDBBuilder.py

Index: zorg/buildbot/builders/LLDBBuilder.py
===================================================================
--- zorg/buildbot/builders/LLDBBuilder.py
+++ zorg/buildbot/builders/LLDBBuilder.py
@@ -93,11 +93,13 @@
 
     # Use batch files instead of ShellCommand directly, Windows quoting is
     # borked. FIXME: See buildbot ticket #595 and buildbot ticket #377.
+    clang_exe = sys.path.join(build_dir, 'bin', 'clang.exe')    # ./bin/clang.exe
     f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
                                 command=[cmake, "-G", "Ninja", "../llvm",
                                          "-DCMAKE_BUILD_TYPE="+config,
                                          '-DPYTHON_HOME=' + python_source_dir,
-                                         "-DCMAKE_INSTALL_PREFIX=../install"]
+                                         "-DCMAKE_INSTALL_PREFIX=../install",
+                                         "-DLLDB_TEST_COMPILER=" + clang_exe]
                                          + extra_cmake_args,
                                 workdir=build_dir))
 
Index: buildbot/osuosl/master/config/builders.py
===================================================================
--- buildbot/osuosl/master/config/builders.py
+++ buildbot/osuosl/master/config/builders.py
@@ -565,7 +565,7 @@
         {'name': "lldb-x86-windows-msvc2015",
          'slavenames': ["zturner-win2008"],
          'builddir': "lldb-windows-x86",
-         'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory(config='Debug')},
+         'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory()},
         {'name': "lldb-x86-win7-msvc",
          'slavenames': ["hexagon-build-01"],
          'builddir': "builddir/lldb-win7-msvc",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19670.55433.patch
Type: text/x-patch
Size: 1752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160428/48c1a827/attachment.bin>


More information about the llvm-commits mailing list