[polly] r267559 - Allow unsigned comparisons

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 07:44:46 PDT 2016


On 04/28/2016 04:39 PM, Johannes Doerfert wrote:
> On 04/28, Tobias Grosser wrote:
>> On 04/27/2016 02:56 PM, Johannes Doerfert wrote:
>>> On 04/27, Tobias Grosser wrote:
>>>> On 04/26/2016 04:33 PM, Johannes Doerfert via llvm-commits wrote:
>>>>> Author: jdoerfert
>>>>> Date: Tue Apr 26 09:33:12 2016
>>>>> New Revision: 267559
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=267559&view=rev
>>>>> Log:
>>>>> Allow unsigned comparisons
>>>>>
>>>>>   With this patch we will optimistically assume that the result of an unsigned
>>>>>   comparison is the same as the result of the same comparison interpreted as
>>>>>   signed.
>>>>
>>>> After this commit, I see a miscompile in
>>>> http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-before-vectorizer-unprofitable/builds/1716
>>> Thank you for noticing.
>>>
>>>   1) I cannot reproduce this locally, queens works fine on my machine.
>>>   2) I just pushed a fixed that fixes a problem we currently have but we
>>>      have to see if it is related.
>>>   3) Can anybody else reproduce the problem locally?
>>
>> I can reproduce this locally with the following command line:
>>
>> mysandbox/bin/lnt runtest nt --sandbox /tmp --cc cmake_opt/bin/clang
>> --test-suite test-suite/ --only-test SingleSource/Benchmarks/Stanford
>> --cflag="-Xclang -load" --cflag="-Xclang
>> /home/grosser/Projects/polly/cmake_opt/lib/LLVMPolly.so"
>> --mllvm=-polly-position=before-vectorizer --mllvm=-polly
>> --mllvm=-polly-process-unprofitable
>>
>> Does this help to reproduce this?
> It did, thanks! r267885 should fix the issue (which was present before
> but exposed by the patch).

Thanks for the fix!

Best,
Tobias



More information about the llvm-commits mailing list