[PATCH] D19236: Add DITypeIndex for CodeView and emit it for locals

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 12:48:51 PDT 2016


rnk added a comment.

In http://reviews.llvm.org/D19236#414087, @dblaikie wrote:

> Generally looks good - should there be more test coverage, though? At least testing one case of a type other than int being generated into the code view? (to demonstrate the new codepath, etc - it looks like the only things testing the CodeView type reference emission are testing the old "everything is int" implementation?)


Yeah, the linker test case has some non-int variables, so I felt covered, but it doesn't actually emit indices to an object file. I changed local-variable.ll to have some 'unsigned' variables so now that's covered.


http://reviews.llvm.org/D19236





More information about the llvm-commits mailing list