[PATCH] D19470: [TLI] Unify LibFunc attribute inference. NFCI.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 12:14:22 PDT 2016


ab added a comment.

Thanks for the reviews!


================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:742
@@ -71,1 +741,3 @@
+      M->getOrInsertFunction("strchr", I8Ptr, I8Ptr, I32Ty, nullptr);
+  inferLibFuncAttributes(*M->getFunction("strchr"), *TLI);
   CallInst *CI = B.CreateCall(
----------------
joker.eph wrote:
> Looks like we could refactor all of these under something like `TLI::get(M, "strchr")`?
Yup, I'm doing that next, separately.


Repository:
  rL LLVM

http://reviews.llvm.org/D19470





More information about the llvm-commits mailing list