[PATCH] D19573: [ThinLTO] Refine fix to avoid renaming of uses in inline assembly.

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D19573#413169, @joker.eph wrote:

> LGTM.
>  This is sketchy though, I'm fine with it on the short term, but anything "clever" using the summary will assume that if you have a summary you have all the informations in the summary for the module somehow, which this is breaking AFAICT.


I don't think it is quite that bad, since in this case we completely prevent building a summary for the module in question, so it should not have a different effect than linking it in as a native object file (where the rest of the bitcode files would have no ability to import from it etc either).

In any case, I do plan to move this to the more refined solution soon, but it isn't at the top of my heap just yet.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:150
@@ +149,3 @@
+      for (auto &BB : F)
+        for (auto &I : BB)
+          if (const CallInst *CallI = dyn_cast<CallInst>(&I))
----------------
joker.eph wrote:
> I think there is a shortcut ` for (auto &I : F.instructions())`
Thanks for the pointer (actually instructions(F), from InstIterator.h)


http://reviews.llvm.org/D19573