[PATCH] D15922: [Cloning] cloneLoopWithPreheader(): add assert to ensure no sub-loops

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: include/llvm/Transforms/Utils/Cloning.h:224
@@ -223,2 +223,3 @@
 /// \p LoopDomBB.  Insert the new blocks before block specified in \p Before.
+/// TODO: Support cloning loops with other loops inside it.
 Loop *cloneLoopWithPreheader(BasicBlock *Before, BasicBlock *LoopDomBB,
----------------
  /// Note: Only inner loops are supported.

(TODO comments in header files are discouraged)

================
Comment at: lib/Transforms/Utils/CloneFunction.cpp:705
@@ -704,2 +704,3 @@
 /// \p LoopDomBB.  Insert the new blocks before block specified in \p Before.
+/// TODO: Support cloning loops with other loops inside it.
 Loop *llvm::cloneLoopWithPreheader(BasicBlock *Before, BasicBlock *LoopDomBB,
----------------
No need to add this here (actually, we shouldn't be duplicating comments like this between header and source files at all).


http://reviews.llvm.org/D15922